Make minimum Julia version v1.6 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 97.48% 97.78% +0.30%
==========================================
Files 109 107 -2
Lines 6318 6194 -124
==========================================
- Hits 6159 6057 -102
+ Misses 159 137 -22 |
|
Not doubting it, but can you say the rationale why 1.6? |
|
1.6 is LTS (see discussion on Slack#graphs) |
simonschoelly
force-pushed
the
set-min-julia-version-to-1.6
branch
from
c25cae1 to
92131de
Compare
ViralBShah
approved these changes
Jan 29, 2022
|
Thanks for approving, as there was no resistance I think this is indeed the way go go. Currently I would like to get as many bug fixes as possible in Graphs.jl, then tag a final |
|
I'll reiterate some of the reasons from slack (from memory):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Julia v1.6 the minimum required version for Graphs.jl.
I also would bump the version of this package to v1.6, so that we could still back port fixes for older Julia versions into the Graphs.jl v1.5.x space, and because it is just nice that the version of Julia then aligns with the of Graphs.jl
If any downstream package has some issues with that, please raise your objections here, but in any case, it should still be possible for you to use Graphs.jl at version v1.5.1.